Make ComponentNameResolverManager a static method#43612
Closed
javache wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
javache
force-pushed
the
export-D55241234
branch
from
7835f6d to
26d5e37
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
javache
force-pushed
the
export-D55241234
branch
from
26d5e37 to
9543840
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
javache
force-pushed
the
export-D55241234
branch
from
9543840 to
dd0926e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
javache
force-pushed
the
export-D55241234
branch
from
dd0926e to
185a3c8
Compare
Summary: Pull Request resolved: facebook#43612 This class is used for a one-time setup of bindings into the jsi::Runtime. The lambda will retain ownership of any java components required, and we can rely on the teardown of the JS runtime to clean up any dependencies. Changelog: [Internal] Reviewed By: dmytrorykun Differential Revision: D55241234
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55241234 |
javache
force-pushed
the
export-D55241234
branch
from
185a3c8 to
dd3e9af
Compare
Contributor
|
This pull request has been merged in 8270e7b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This class is used for a one-time setup of bindings into the jsi::Runtime. The lambda will retain ownership of any java components required, and we can rely on the teardown of the JS runtime to clean up any dependencies.
Changelog: [Internal]
Differential Revision: D55241234